Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional custom index settings in vectorstore #55

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

giacbrd
Copy link
Contributor

@giacbrd giacbrd commented Nov 28, 2024

Hi, I have simply added a parameter to the ElasticsearchStore class in order to set default settings at index creation, that is made by the VectorStore helper in the Elasticsearch library. It is just arguments traversing calls, there is not much to test. There is also another minor fix in the doctring.

The main benefit of this parameter is to pre-configure the index when using the Elasticsearch vector store, which implicitly creates an index when first documents are added. One can, for example, set a correct number of replicas for his cluster, so that he has not to change it manually after creation, with all the waste of computational effort this implies

@giacbrd
Copy link
Contributor Author

giacbrd commented Nov 28, 2024

@miguelgrinberg I had a minor problem: unasync is not a dependency in pyproject.toml, nor is isort. Is this regular?

@miguelgrinberg
Copy link
Collaborator

@giacbrd Yes, that is a problem, looks like I missed adding those as dev dependencies in the project files. Thanks.

@miguelgrinberg miguelgrinberg merged commit 686575c into langchain-ai:main Dec 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants