use sed to change get_messages() to messages

langchain-ai · Nov 27, 2024 · ea55fd1 · ea55fd1
1 parent 56e6b7b
commit ea55fd1
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 12 deletions.
diff --git a/libs/elasticsearch/langchain_elasticsearch/_sync/cache.py b/libs/elasticsearch/langchain_elasticsearch/_sync/cache.py
@@ -201,8 +201,8 @@ def clear(self, **kwargs: Any) -> None:
 class ElasticsearchEmbeddingsCache(ByteStore):
     """An Elasticsearch store for caching embeddings.
 
-    For synchronous applications, use the ``ElasticsearchEmbeddingsCache`` class.
-    For asyhchronous applications, use the ``AsyncElasticsearchEmbeddingsCache`` class.
+    For synchronous applications, use the `ElasticsearchEmbeddingsCache` class.
+    For asyhchronous applications, use the `AsyncElasticsearchEmbeddingsCache` class.
     """
 
     def __init__(

diff --git a/libs/elasticsearch/scripts/run_unasync.py b/libs/elasticsearch/scripts/run_unasync.py
@@ -113,23 +113,19 @@ def main(check=False):
         subprocess.check_call(["ruff", "format", "--target-version=py38", output_dir])
         subprocess.check_call(["isort", output_dir])
         for file in glob("*.py", root_dir=dir[0]):
-            # remove asyncio from sync files
-            subprocess.check_call(
-                ["sed", "-i.bak", "/^import asyncio$/d", f"{output_dir}{file}"]
-            )
             subprocess.check_call(
                 [
                     "sed",
                     "-i.bak",
-                    "s/asyncio\\.run(main())/main()/",
+                    "s/pytest.mark.asyncio/pytest.mark.sync/",
                     f"{output_dir}{file}",
                 ]
             )
             subprocess.check_call(
                 [
                     "sed",
                     "-i.bak",
-                    "s/pytest.mark.asyncio/pytest.mark.sync/",
+                    "s/get_messages()/messages/",
                     f"{output_dir}{file}",
                 ]
             )

diff --git a/libs/elasticsearch/tests/integration_tests/_async/test_chat_history.py b/libs/elasticsearch/tests/integration_tests/_async/test_chat_history.py
@@ -60,7 +60,7 @@ async def test_memory_with_message_store(
         )
 
         # get the message history from the memory store and turn it into a json
-        messages = await memory.chat_memory.aget_messages()  # type: ignore[attr-defined]
+        messages = await memory.chat_memory.aget_messages()
         messages_json = json.dumps([message_to_dict(msg) for msg in messages])
 
         assert "This is me, the AI" in messages_json
@@ -69,4 +69,4 @@ async def test_memory_with_message_store(
         # remove the record from Elasticsearch, so the next test run won't pick it up
         await memory.chat_memory.aclear()
 
-        assert await memory.chat_memory.aget_messages() == []  # type: ignore[attr-defined]
+        assert await memory.chat_memory.aget_messages() == []
diff --git a/libs/elasticsearch/tests/integration_tests/_sync/test_chat_history.py b/libs/elasticsearch/tests/integration_tests/_sync/test_chat_history.py
@@ -60,7 +60,7 @@ def test_memory_with_message_store(
         )
 
         # get the message history from the memory store and turn it into a json
-        messages = memory.chat_memory.get_messages()  # type: ignore[attr-defined]
+        messages = memory.chat_memory.messages
         messages_json = json.dumps([message_to_dict(msg) for msg in messages])
 
         assert "This is me, the AI" in messages_json
@@ -69,4 +69,4 @@ def test_memory_with_message_store(
         # remove the record from Elasticsearch, so the next test run won't pick it up
         memory.chat_memory.clear()
 
-        assert memory.chat_memory.get_messages() == []  # type: ignore[attr-defined]
+        assert memory.chat_memory.messages == []