Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Fix: ensure runnability of samples/agents #313

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

danielykim
Copy link

Type of Issue

  • Other

Description

This PR includes improvements to two notebook examples in the samples/agents directory to enhance runnability and consistency:

  1. samples/agents/bedrock_agent_langgraph.ipynb
  2. samples/agents/bedrock_agent_roc.ipynb

Key Changes

1. samples/agents/bedrock_agent_langgraph.ipynb

Reason for changes:

  • on Step 3: Avoid using hard-coded variables by getting region names from boto3.session.Session()
  • on Step 4: To ensure runnability by changing foundational_model as foundation_model
  • on Step 5: Remove unused import
  • on Step 6: ToolExecutor is deprecated as of version 0.2.0 and will be removed in 0.3.0.

2. samples/agents/bedrock_agent_roc.ipynb

  • on Step 2 & 4: to make the variable name consistent with the argument of BedrockAgentsRunnable.create_agent()
  • on Step 3: Avoid using hard-coded variables by getting region names from boto3.session.Session()

Test Configuration

  • Python: 3.11.10
  • OS/Distribution: Ubuntu 22.04.5 LTS

Review Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant