Semantic cache for InMemory Vector store #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3coins
reviewed
Oct 3, 2024
There was a problem hiding this comment.
@LakshmiPeri23
Thanks for submitting this change. Should this be part of caches module, rather than root?
I saw even tn elangchain code cache is in root and not moved to a seperate module so left the same format. |
|
i will work on addressing remaining feedback and submit the changes |
Let's add it inside the cache module. We can add an export inside the root, so users can import from root. |
3coins
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cache.py which provide Semantic Caching functionality to store question and answers in MemoryDB. Inlucded an example SemanticCache.ipynb jupyter notebook for test