Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws[patch]: fix ChatBedrockConverse init #200

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

baskaryan
Copy link
Collaborator

@baskaryan baskaryan commented Sep 18, 2024

Make sure supports_tool_choice_values is set whether or not client is passed in

Copy link
Collaborator

@3coins 3coins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@3coins
Copy link
Collaborator

3coins commented Sep 18, 2024

Would be nice to backport these changes to v0.1.

@baskaryan baskaryan merged commit cf435cf into main Sep 19, 2024
12 checks passed
@baskaryan baskaryan deleted the bagatur/fix_converse_init branch September 19, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants