Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colour output #25

Open
landro opened this issue Dec 8, 2013 · 11 comments
Open

Add colour output #25

landro opened this issue Dec 8, 2013 · 11 comments

Comments

@landro
Copy link
Owner

landro commented Dec 8, 2013

green ok
red failed

landro added a commit that referenced this issue Dec 8, 2013
@landro
Copy link
Owner Author

landro commented Dec 9, 2013

screen shot 2013-12-09 at 7 49 48 am

@landro
Copy link
Owner Author

landro commented Dec 9, 2013

@Sebastian-Brzuzek, could you give this a go on a windows machine and pull and merge if ok?

@Sebastian-Brzuzek
Copy link
Contributor

@landro I just executed tests and examples on WinXP and have a lot of errors like this one:

Unexpected unknown command invocation 'exec tput -S << setaf'

Maybe you should add an "on" statement similar to the one below to your "it" block?

    it "your description" {
      ...
      on exec tput -S << setaf return "your return value"
      ...
    }

I'm not sure if my environment is setup in correct way, so I will try to test it on Win7 in the evening and let you know if it is the same. I have no time Today to try to fix it, but I will try to look on it during next days.

@landro
Copy link
Owner Author

landro commented Dec 9, 2013

@Sebastian-Brzuzek It might be related to the disabled exec command. I enabled it again to make this work. Make sure you have a clean repo - maybe the easiest is to check out the coloured_messages branch

@Sebastian-Brzuzek
Copy link
Contributor

@landro I was testing on clean check out of the coloured_messages branch, so this is not related to disabled exec command (I was using jtcl to be sure there is no problem with tcl interpreter).

@Sebastian-Brzuzek
Copy link
Contributor

@landro I just executed test.cmd on Win7 - result shared here https://gist.github.com/Sebastian-Brzuzek/7878312
There is no error when I run examples.cmd
I'm sure this is related to coloured messages not with environment - there is no error when I run tests.cmd from main branch

@landro
Copy link
Owner Author

landro commented Dec 9, 2013

@Sebastian-Brzuzek Oh man, totally forgot about updating and running these tests. Should be ok now. Would you mind retesting it quick?
I notice by the way that exec from jtcl is kinda slow some times, and if you hit enter to fast between the tests, the stream is closed, at least on my mac.
By the way, I presume you don't see any color coded output on windows, is that correct?

@Sebastian-Brzuzek
Copy link
Contributor

@landro now it looks much better. There are no errors. Your assumption about lack of colours in windows command line is correct as well. I will merge this branch to main in spare time today

@landro
Copy link
Owner Author

landro commented Dec 10, 2013

Hi,

Please wait a little before you merge. I'll send a pull request when ready.

Stefan

Sendt fra min iPhone

Den 10. des. 2013 kl. 04:35 skrev Sebastian Brzuzek [email protected]:

@landro now it looks much better. There are no errors. Your assumption about lack of colours in windows command line is correct as well. I will merge this branch to main in spare time today


Reply to this email directly or view it on GitHub.

@Sebastian-Brzuzek
Copy link
Contributor

OK. Let me know when there will be final version available (I will try to find the reason of problem on WinXP in the mean time, but we should not wait if it will be difficult to fix on this obsolete platform).

Seba.

@Sebastian-Brzuzek
Copy link
Contributor

I found there was incorrect setup of TCLLIBPATH in my WinXP environment pointing to some obsolete version of TesTcl. After cleanup of this environment varialble it looks even on WinXP everything works as expected - both tests.cmd and examples.cmd passed without errors.

Cheers,
Seba.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants