Refactor dataset diff and compute metric #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changhiskhan
force-pushed
the
changhiskhan/refactor
branch
2 times, most recently
from
f445bf6
to
9165a2c
Compare
changhiskhan
force-pushed
the
changhiskhan/refactor
branch
from
9165a2c
to
921260c
Compare
changhiskhan
changed the title
eddyxu
reviewed
Dec 18, 2022
python/lance/_lib.pyx
Outdated
|
|
||
| Parameters | ||
| ---------- | ||
| metric_func: FileSystemDataset -> pd.DataFrame |
There was a problem hiding this comment.
Callalble[[FileSystmeDataset], pd.DataFrame]
python/lance/_lib.pyx
Outdated
| def compute_metric(self, metric_func: Callable[[Dataset], pd.DataFrame], | ||
| versions: list[int] = None) -> pd.DataFrame: | ||
| """ | ||
| Compute a metric across versions for this dataset |
There was a problem hiding this comment.
Main concerns are the stability / maturity of these two APIs.
There was a problem hiding this comment.
as discussed, moved to lance/__init__.py and not as a Dataset method
python/lance/_lib.pyx
Outdated
| metric_func: FileSystemDataset -> pd.DataFrame | ||
| Function to compute some arbitrary metric for a given version | ||
| versions: list of int, default None | ||
| Compute for specified versions. Compute for all versions if None. |
There was a problem hiding this comment.
Should the default behavior to just compute metrics for latest version ?
There was a problem hiding this comment.
i don't think you'd really need this method then. If you just wanted to compute on latest version, metric_func(ds) is simpler than compute_metrics(ds, metric_func). wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ds.compute_metric(func)andds.diff(v1, v2)to dataset interface