Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds crate-ci/typos to check repository's spelling #3022

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

broccoliSpicy
Copy link
Contributor

@broccoliSpicy broccoliSpicy commented Oct 18, 2024

This PR tries to introduce the spelling check workflow from typos to ensure we have correct spelling in our repository.

@github-actions github-actions bot added the chore label Oct 18, 2024
@broccoliSpicy broccoliSpicy changed the title chore: adds crate-ci/[email protected] to check repository's spelling chore: adds crate-ci/typos to check repository's spelling Oct 18, 2024
Copy link
Contributor

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these extend beyond just comment changes but I don't think I see any code changes that would impact the public API.

@westonpace
Copy link
Contributor

(also, need CI to pass before merging)

@broccoliSpicy
Copy link
Contributor Author

Some of these extend beyond just comment changes but I don't think I see any code changes that would impact the public API.

yeah, many code variable names and field names are also affected in this PR change

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 74.24242% with 17 lines in your changes missing coverage. Please review.

Project coverage is 78.16%. Comparing base (f9024ce) to head (fd3807b).

Files with missing lines Patch % Lines
rust/lance/src/index/vector/ivf.rs 25.00% 1 Missing and 2 partials ⚠️
java/core/lance-jni/src/blocking_dataset.rs 0.00% 2 Missing ⚠️
rust/lance-core/src/datatypes.rs 0.00% 2 Missing ⚠️
rust/lance-datagen/src/generator.rs 50.00% 2 Missing ⚠️
rust/lance-datafusion/src/exec.rs 0.00% 1 Missing ⚠️
.../lance-encoding/src/encodings/logical/primitive.rs 0.00% 1 Missing ⚠️
rust/lance-index/src/vector/pq.rs 0.00% 1 Missing ⚠️
rust/lance-index/src/vector/utils.rs 0.00% 1 Missing ⚠️
rust/lance-table/src/io/commit/dynamodb.rs 90.00% 1 Missing ⚠️
rust/lance/src/dataset/fragment.rs 80.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3022      +/-   ##
==========================================
- Coverage   78.19%   78.16%   -0.04%     
==========================================
  Files         239      239              
  Lines       76782    76782              
  Branches    76782    76782              
==========================================
- Hits        60043    60016      -27     
- Misses      13669    13673       +4     
- Partials     3070     3093      +23     
Flag Coverage Δ
unittests 78.16% <74.24%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants