Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow optimize indices to control index merge behavior #1820

Closed
wants to merge 19 commits into from

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Jan 12, 2024

Allow users to specify how many indices to merge together. Can choose a non-negative integer.

@eddyxu eddyxu marked this pull request as draft January 12, 2024 06:24
@eddyxu eddyxu self-assigned this Jan 15, 2024
@eddyxu eddyxu added rust Rust related tasks vector Vector Search labels Jan 15, 2024
changhiskhan and others added 13 commits January 15, 2024 19:57
[Half 2.3](https://github.com/starkat99/half-rs/releases/tag/v2.3.0)
supports f16 HW acceleration. This is safe because our rust crate
already uses 2.3.1
BREAKING CHANGE: removed single-purpose stats API from public API and
refactored `DatasetIndexExt` to `lance-index`.

Also, fixed a few places that `unwrap()` results.
Clean pu leftovers from #1828
During compaction we read in the row ids so we can use them for
remapping. We read the row ids into a tree map which is most efficient
if we can read them in order and the current code is in fact assuming
that the row ids arrive in order. However, we weren't actually scanning
in order and this could lead to failures during compaction.
add a E2E test for torch training where the training data contains nans
I've given up for now on supporting generic extension types in FSL
(#1693), so for now we'll have a special case for bfloat16 where we have
a specific string that refers to our extension type.

This will unblock further development on vector search with bfloat16,
but there is also still substantial UX work before we want to advertise
this to users.

Closes #1684.
allow python users to set custom PQ codebook calculated from external
sources
@eddyxu
Copy link
Contributor Author

eddyxu commented Jan 17, 2024

Closes in favor of #1841

@eddyxu eddyxu closed this Jan 17, 2024
@eddyxu eddyxu deleted the lei/optimize_indices branch February 26, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Rust related tasks vector Vector Search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants