Fix NeoPixel/WS2812B timing. #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change frequency from 500kHz to 800kHz to match datasheet. - Updating high & low timings to match make:code. Tested on a variety of WS2812B strips as well as SK6812 RGB and RGBW strips. Signed-off-by: Jim Mussared <[email protected]>
|
Looks a sensible patch to me! Lets get this merged in. |
|
Thanks @JohnVidler for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on a variety of WS2812B strips as well as SK6812 RGB and RGBW strips and APA104 used by newer revisions of the Seeed Bit Kit micro:car.
Fixes lancaster-university/codal-microbit-v2#294 (cc @microbit-carlos @finneyj )