Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added definitions to match the Makecode effects parameters #417

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Added definitions to match the Makecode effects parameters #417

merged 1 commit into from
Mar 27, 2024

Conversation

JohnVidler
Copy link
Collaborator

As per the title, just a set of definitions for downstream languages to use.

@JohnVidler JohnVidler added enhancement New feature or request micropython labels Mar 26, 2024
@JohnVidler JohnVidler added this to the v0.2.67 milestone Mar 26, 2024
@JohnVidler JohnVidler self-assigned this Mar 26, 2024
@JohnVidler JohnVidler mentioned this pull request Mar 26, 2024
Closed
@github-actions GitHub Actions
Copy link

Build diff

Base commit: 08ba1e75fa86b2f4807a87e6b555e0efb1e712a8
Action run: https://github.com/lancaster-university/codal-microbit-v2/actions/runs/8438814288

     VM SIZE    
 -------------- 
  [ = ]       0    TOTAL

@microbit-carlos
Copy link
Collaborator

@dpgeorge just to check this works for MicroPython?

@microbit-carlos microbit-carlos mentioned this pull request Mar 26, 2024
Closed
@dpgeorge
Copy link

Yes, this should work for MicroPython.

microbit-carlos
microbit-carlos approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@microbit-carlos microbit-carlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to be merged 👍

@microbit-carlos microbit-carlos merged commit 9a03c69 into master Mar 27, 2024
13 checks passed
@microbit-carlos microbit-carlos deleted the feature/default-fx-param branch March 27, 2024 09:44
@microbit-carlos microbit-carlos removed this from the v0.2.67 milestone Mar 28, 2024
@dpgeorge
Copy link

Actually, this doesn't work for MicroPython because we use C and can't include a C++ header in C code...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microbit-carlos microbit-carlos microbit-carlos approved these changes

Assignees

@JohnVidler JohnVidler

Labels
enhancement New feature or request micropython
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnVidler @microbit-carlos @dpgeorge