Update MicroBitLog to support 3 header formats #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuration via MICROBIT_LOG_MODE. Values: 0: data.microbit.org data logging experience 1: basic experience supported by dl.js in this repository hosted on microbit.org 2: "BBC micro:bit - the next gen" playground survey experience (this requires a specific HEX to generate the relevant data format)
Build diffBase commit: d54ce9b784ef1bba22c075b281bb877abf53ea18 |
Build diffBase commit: d54ce9b784ef1bba22c075b281bb877abf53ea18 |
|
Looks good to me, squashing down to test with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration via MICROBIT_LOG_MODE. Values:
0: data.microbit.org data logging experience
1: basic experience supported by dl.js in this repository hosted on microbit.org
2: "BBC micro:bit - the next gen" playground survey experience
(this requires a specific HEX to generate the relevant data format)
Related PR: lancaster-university/microbit-v2-samples#84
That has a demo that generates the sample here.