Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI MicroPython: Don't checkout submodules recursively. #351

Merged
merged 1 commit into from
Jul 14, 2023
Merged

CI MicroPython: Don't checkout submodules recursively. #351

merged 1 commit into from
Jul 14, 2023

Conversation

microbit-carlos
Copy link
Collaborator

@microbit-carlos microbit-carlos commented Jul 14, 2023 •
edited
Loading

Is not necessary and as MicroPython contains a lot of submodules with SDKs and similar it takes a long time to pull submodules recursively.

With this change CI build time goes down from 8 to 1 minute.

image

@microbit-carlos
CI uPy: Don't checkout submodules recursively.
5e300c0 
Is not neccesary and as MicroPython contains a lot of submodules
with SDKs and similar it takes a long time to pull submodules
recursively.
@microbit-carlos microbit-carlos changed the title CI uPy: Don't checkout submodules recursively. CI MicroPython: Don't checkout submodules recursively. Jul 14, 2023
@github-actions
Copy link

Build diff

Base commit: ac703214e88b8f3dba1df50c2e2af282b98f60d5
Action run: https://github.com/lancaster-university/codal-microbit-v2/actions/runs/5555644000

     VM SIZE    
 -------------- 
  [ = ]       0    TOTAL

microbit-carlos
microbit-carlos commented Jul 14, 2023
View reviewed changes
Copy link
Collaborator Author

@microbit-carlos microbit-carlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a CI-only change and the respective jobs have finished successfully it doesn't need further review and can be merged directly.

@microbit-carlos microbit-carlos merged commit 16b1867 into master Jul 14, 2023
@microbit-carlos microbit-carlos deleted the ci-upy-submodules branch July 14, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@microbit-carlos