Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI MakeCode: Use the default pxt-core and pxt-common-packages from package.json #308

Merged
merged 1 commit into from
May 18, 2023

Conversation

microbit-carlos
Copy link
Collaborator

For the MakeCode developer instructions they recommend to clone the repost and use the latest commit from the main branch, so the CI was installing the latest versions submitted to npm. However, the projects can be slightly out of sync and cause build problems:

Relaying on the pxt-core and pxt-common-packages versions installed from package.json should be more stable.

@github-actions
Copy link

Build diff

Base commit: 2aa9b495804d664cc29fd021ec889bcf074b50d3
Action run: https://github.com/lancaster-university/codal-microbit-v2/actions/runs/4832943757

     VM SIZE    
 -------------- 
  [ = ]       0    TOTAL

Copy link
Collaborator Author

@microbit-carlos microbit-carlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I've re-run the CI and is still all good.
I'll merge now as this is a CI only change and if something is off I can fix it tomorrow before I go.

@microbit-carlos microbit-carlos merged commit e11f61e into master May 18, 2023
@microbit-carlos microbit-carlos deleted the ci-pxt branch June 15, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant