Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove target.json DEVICE_DMESG_BUFFER_SIZE value to use the defaults. #298

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

microbit-carlos
Copy link
Collaborator

So that the value can be automatically be set to zero if DEVICE_DMESG is not defined or set 1.

This PR goes together with:

And is discussed in:

So that the value can be automatically be set to zero if DEVICE_DMESG
is not defined or set 1.
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Build diff

Base commit: be35cc1d13697a783e08658a94e3af2b6c1afc4e
Action run: https://github.com/lancaster-university/codal-microbit-v2/actions/runs/4620890718

     VM SIZE    
 -------------- 
  [ = ]       0    TOTAL

Copy link
Collaborator Author

@microbit-carlos microbit-carlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed on a call with @finneyj and @JohnVidler and ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant