-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FFT example #291
Draft
microbit-carlos
wants to merge
6
commits into
master
Choose a base branch
from
fft_rebased
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
FFT example #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microbit-carlos
force-pushed
the
fft_rebased
branch
from
March 29, 2023 17:02
e3319f4
to
df09b08
Compare
microbit-carlos
force-pushed
the
fft_rebased
branch
from
March 29, 2023 17:12
df09b08
to
7adab7c
Compare
Signed-off-by: Raphael Gault <[email protected]> Merged CMakeLists.txt target link libraries with master - includes relevant CMSIS libraries.
Signed-off-by: Raphael Gault <[email protected]>
Signed-off-by: Raphael Gault <[email protected]>
…BitAudioProcessor and sample fft C++ Program
microbit-carlos
force-pushed
the
fft_rebased
branch
from
March 29, 2023 17:29
7adab7c
to
b40eed7
Compare
Although it currently calculates frequencies that are twice the signal frequency, but that might be a simple fix once somebody can look into the audio configuration.
microbit-carlos
force-pushed
the
fft_rebased
branch
from
March 29, 2023 20:20
b40eed7
to
22920ba
Compare
microbit-carlos
force-pushed
the
fft_rebased
branch
from
April 6, 2023 16:06
3d6888d
to
cc0d402
Compare
microbit-carlos
force-pushed
the
fft_rebased
branch
from
April 6, 2023 16:12
cc0d402
to
b6dca85
Compare
Build diffBase commit: be35cc1d13697a783e08658a94e3af2b6c1afc4e
|
3 tasks
Next steps for this work:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviving the branch originally developed by Raphael and updated by Joshua.
This is not really mergeable on this state as the CMSIS libs are added as a submodule to this repo and it changes the
float-abi
compiler flag tohard
(we need to check if we can compile the CMSIS DSP code withfloat-abit=softfp
).Maybe it's worth considering moving this as a "CODAL library" that can also be used as a MakeCode extension, as the
MicroBitAudioProcessor
class is a fairly self-containedDataSink
.I'm not sure if I've wired the right DataSource to
MicroBitAudioProcessor
as a I get a lot high frequency values in a relatively quiet room (do we have a DataSource that has filtered out noise?) and the calculated frequencies are twice as expected.codal-microbit-v2/samples/fft_example.cpp
Lines 18 to 37 in e3319f4
Also, it looks like CMSIS needs CMake 3.13 min, and that's a newer version than the Yotta docker image, so the MakeCode builds will fail.