Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix REPL shadowing bug #16389

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Fix REPL shadowing bug #16389

merged 1 commit into from
Nov 23, 2022

Conversation

dwijnand
Copy link
Member

No description provided.

@dwijnand dwijnand mentioned this pull request Nov 21, 2022
Merged
@dwijnand dwijnand linked an issue Nov 21, 2022 that may be closed by this pull request
REPL: scala.* namespaces shadow other classes #15904
Closed
@som-snytt
Copy link
Contributor

I've only a minute between grocery shopping and chauffeuring to piano lesson. I didn't grok in a minute. It was about 0.5 grok/min.

I recognize checking for repl wrapper aka Wrapl.

@som-snytt som-snytt closed this Nov 22, 2022
@som-snytt
Copy link
Contributor

I swear I did not close this.

@som-snytt som-snytt reopened this Nov 22, 2022
@mpollmeier
Copy link
Contributor

Probably not required, but just to add more evidence I manually tested that this fixes #15904 (which it does). Thank you!

@dwijnand
Copy link
Member Author

Excellent, thank you. I had the io test in ShadowingTests as the failing reproduction, but it's good to check manually too.

@dwijnand dwijnand marked this pull request as ready for review November 22, 2022 12:52
@dwijnand dwijnand requested a review from griggt November 22, 2022 12:53
@som-snytt
Copy link
Contributor

Nice! and easy!

@dwijnand dwijnand requested review from som-snytt and removed request for griggt November 23, 2022 08:54
@dwijnand dwijnand assigned som-snytt and unassigned griggt Nov 23, 2022
@dwijnand dwijnand merged commit c896c46 into scala:main Nov 23, 2022
@dwijnand dwijnand deleted the fix-repl-shadowing1 branch November 23, 2022 11:14
@Kordyjan Kordyjan added this to the 3.3.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpollmeier mpollmeier mpollmeier left review comments

@som-snytt som-snytt som-snytt approved these changes

Assignees

@som-snytt som-snytt

Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

REPL: scala.* namespaces shadow other classes
5 participants
@dwijnand @som-snytt @mpollmeier @Kordyjan @griggt