Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SemanticDB] Support overridden_symbols #13295

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

tanishiking
Copy link
Member

#12963


At this moment, overridden_symbol is not used by metals or scalafix rules as far as I know, but this field could be useful for

@@ -2544,7 +2544,7 @@ example/A#`<init>`(). => primary ctor <init> (): A
example/A#foo(). => abstract method foo => Int
example/B# => class B extends Object with A { self: B => +2 decls }
example/B#`<init>`(). => primary ctor <init> (): B
example/B#foo(). => method foo => Int
example/B#foo(). => method foo => Int <: example/A#foo().
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local18 => type T1
local19 => type T2 = T1
local18 => type T1 <: example/C#T1#
local19 => type T2 = T1 <: example/C#T2#
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exports/example/Codec#decode().(a) => param a: Array[Byte]
exports/example/Codec#decode. => private[this] val method decode Decoder[T]
exports/example/Codec#encode(). => final method encode (param t: T): Array[Byte]
exports/example/Codec#encode(). => final method encode (param t: T): Array[Byte] <: exports/example/Encoder#encode().
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you

@bishabosha bishabosha merged commit b1ac51a into scala:master Aug 17, 2021
@tanishiking tanishiking deleted the overridden-symbols branch August 17, 2021 17:40
@Kordyjan Kordyjan added this to the 3.1.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants