Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing SymbolInfomation fields to Semanticdb #12963

Open
8 of 10 tasks
tanishiking opened this issue Jun 28, 2021 · 0 comments
Open
8 of 10 tasks

Add missing SymbolInfomation fields to Semanticdb #12963

tanishiking opened this issue Jun 28, 2021 · 0 comments

Comments

@tanishiking
Copy link
Member

tanishiking commented Jun 28, 2021

Current ExtractSemanticDB in dotty extracts the following information for SymbolInformation, but there're some missing fields.

https://github.com/lampepfl/dotty/blob/f33bc8df9bbdabb921fe70b0d136cb3fd4f25355/compiler/src/dotty/tools/dotc/semanticdb/ExtractSemanticDB.scala#L453-L460

message SymbolInformation {
  reserved 2, 6, 7, 8, 9, 10, 11, 12, 14, 15;
  string symbol = 1;
  Language language = 16;
  Kind kind = 3;
  int32 properties = 4;
  string display_name = 5;
  Signature signature = 17;
  repeated Annotation annotations = 13;
  Access access = 18;
  repeated string overridden_symbols = 19;
  Documentation documentation = 20;
}

https://scalameta.org/docs/semanticdb/specification.html#symbolinformation

Expectation

Dotty should extract all the fields of SymbolInformation.

(note that, documentation could be in lower priority IMO, since semanticdb plugin for scala2 also doesn't extract it and no tools depend on that information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants