This repository has been archived by the owner on Jun 15, 2024. It is now read-only.
Support PostgreSQL and add PosgreSQL/SQLite for CI testing #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpyw
approved these changes
Jan 5, 2020
| @@ -112,7 +119,7 @@ protected function compileSelect(Select $select) | |||
| 'alias' => $model->alias, | |||
| 'table' => $db->fullTableName($model), | |||
| 'fields' => [ | |||
| "{$model->alias}.{$model->primaryKey}", | |||
| $db->name("{$model->alias}.{$model->primaryKey}"), | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PostgreSQL, when a statement has an alias for a table, expressions in SELECT clause must refer to the field in FROM clause in exactly the same way as the alias including its quotation.
As CakePHP automatically quotes the fields in SELECT clause, lampager-cakephp2 has to quote them as well before passing them to
buildStatement().