-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Better error behavior for repeated calls of standardize
#2266
Conversation
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
standardize
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2266 +/- ##
==========================================
+ Coverage 92.71% 92.89% +0.17%
==========================================
Files 55 55
Lines 6947 7177 +230
==========================================
+ Hits 6441 6667 +226
- Misses 506 510 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Signed-off-by: zethson <[email protected]>
Ahh, main is broken because of the I guess I'll wait with the above until this here is merged. |
If you still have your source, we can go for B. It's less overwhelming and I like numbered changes. Easier to refer to. |
Fixes #2262
Fixes KeyError formatting
Before
KeyError: '\"cell_line\" is not a valid key, available keys are: \\'well\\', \\'sirna\\'!'"
After
KeyError: "'cell_line' is not a valid key, available keys are: 'well', 'sirna'!"
Fixes repeated calls of
standardize()
Before
led to a traceback with 'KeyError: 'disease' is not a valid key.
After
• No unstandardized values found for 'disease'
Now hides the
add_new_from_columns
method from sphinxBefore this PR, the deprecated
add_new_from_columns
method was still listed in our documentation. It is now hidden.