Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 for circular input/outputs #2041

Merged
merged 1 commit into from
Oct 10, 2024
Merged

🎨 for circular input/outputs #2041

merged 1 commit into from
Oct 10, 2024

Conversation

sunnyosun
Copy link
Member

No description provided.

@sunnyosun sunnyosun merged commit f5d3b4d into main Oct 10, 2024
13 checks passed
@sunnyosun sunnyosun deleted the fix-circular-lineage branch October 10, 2024 17:37
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.39%. Comparing base (5abfc41) to head (a2d5945).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
lamindb/_parents.py 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2041      +/-   ##
==========================================
+ Coverage   92.26%   92.39%   +0.12%     
==========================================
  Files          54       54              
  Lines        6324     6340      +16     
==========================================
+ Hits         5835     5858      +23     
+ Misses        489      482       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@github-actions github-actions bot temporarily deployed to pull request October 10, 2024 17:40 Inactive
@falexwolf
Copy link
Member

This is great as it also helps us to understand the edge cases in which users manage to fabricate a cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 view_lineage() never completes if run output_artifacts contains a subset of input_artifacts
2 participants