-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add submodule for entry point functionality #844
Conversation
Thanks, Andreas! I'll fix the CI runs here: What test shall we add for this? |
Good question, since the test will at the end rely on lamindb, lamin-cli and lamindb-setup it would be great if you could advise where I should add tests ideally. In every dependency? or only in lamindb? |
I get how it works for CLI calls.
I'll read up in the original issue for how it would be called for lamindb. Would you want this to be automatically called upon importing lamindb? |
Regarding tests: Tests pass on the main branch. 🤔 - It must be related to the fact that you made the PR with different hidden policies or settings that they're now failing. 🤔 |
Hmm, could be that it's related to me not being part of your org. Have you ever had external contributors? |
Yes, we did. 🤔 -- I'll investigate, and get this to work, don't worry. |
Regarding the general layout, I'm responding in the original issue. |
perfect. I'll add tests and will reopen from a branch in laminlabs/lamindb-setup |
Hello Lamins,
This PR adds an
_entry_points
submodule with acall_registered_entry_points
function, which can then be used inlamindb
as well aslamin-cli
to provide a hook that other packages can use to do additional setup that might be required for lamindb to function correctly within their custom infrastructure.usage example xref: laminlabs/lamin-cli#68
Cheers,
Andreas 😃