Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Use shutil.move instead of Path.rename #86

Merged
merged 1 commit into from
Oct 2, 2024
Merged

🐛 Use shutil.move instead of Path.rename #86

merged 1 commit into from
Oct 2, 2024

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Oct 2, 2024

@Koncopd Koncopd merged commit 8ed07ba into main Oct 2, 2024
@Koncopd Koncopd deleted the fix_rename branch October 2, 2024 08:11
@falexwolf
Copy link
Member

Thanks, Sergei!

Just: we should always add comments when do this. I've added comments in other places because when I read this code I'm otherwise like: "why don't we use rename?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants