Update Composer lock file and fix test failures #70
Conversation
Signed-off-by: George Steel <[email protected]>
…ch as Router v3 is required in dev. Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
…here support for the Router namespace change was added Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
|
The UrlIntegrationTest is problematic in that it is unclear to me why a legacy console request is expected. I believe that in the past we may have been able to guarantee a console request was present. Given that Console itself is deprecated, can this test be left in a flaky state, given that the expected output is still the same? I would imagine that the test will be deleted in the not too distant future anyhow… Paging @Ocramius for review :) |
gsteel
changed the title
Probably for testing purposes - the test is most likely there to ensure BC compatibility.
Sadly not: deprecation is not removal of support.
On the |
| @@ -89,10 +86,6 @@ protected function setUp(): void | |||
| { | |||
| $cwd = __DIR__; | |||
|
|
|||
| $this->routeMatchType = class_exists(V2RouteMatch::class) | |||
There was a problem hiding this comment.
This conditional indicates that we can deal with V2 or V3. Can we somehow reduce that via composer.json restrictions (support only one version)?
There was a problem hiding this comment.
I've made the minimum version of Laminas\Navigation ^2.8.1 in dev which is the version where support was added for Laminas\Router vs Laminas\Mvc\Router.
There was a problem hiding this comment.
Does "laminas/laminas-router": "^3.0.1", cover that then?
There was a problem hiding this comment.
I assumed that if --dev will only install v3, then it's simply not possible to test against v2 without changing the dev requirement of router to 2||3 or something like that - so 2.8.1 of navigation fixes the test failures and renders the checks for v2 router obsolete???
There was a problem hiding this comment.
P.S. I think that the dev requirement of navigation could actually be bumped 2.9.x due to 7.3 support getting added around that release
There was a problem hiding this comment.
We can add a "conflict": {"laminas/laminas-router": "<3.0.1"} to solve that
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
…omponent' into 2.12.x Fixes #70
|
This was manually merged, thanks @gsteel! |
Description
Updates the composer lock file with i18n-mvc and flash messenger packages.
Laminas\Mvc\RoutertoLaminas\RouterUrlIntegrationTestshould still fail because the request retrieved from the container is not aConsoleRequest