added missing allowed types to constructor (#239)

[ppaulis]

Q	A
Documentation	no
Bugfix	yes
BC Break	no
New Feature	no
RFC	no
QA	no

Description

This bugfix addresses the issue #239 by allowing lists in the constructor of ViewModel.

[Ocramius]

Closing as invalid: these types are too wide, even if the more internal setVariables() is not as restrictive

[Ocramius]

I'd say that all the int-keyed values should be rejected.

Yes, it works in practice: no, it shouldn't be allowed, and there's no guarantee that it will.

[ppaulis]

@Ocramius Thanks for the quick reply :-)
So, to be sure that I understand you correctly : If I want to return in my Laminas Api Tools RPC Controller something like :

[
  {
    "field1": "value1",
    "field2": "value2"
  },
  {
    ..
  },
  ..
]

JsonModel/ViewModel shouldn't be used?

[Ocramius]

ViewModel: probably not.
JsonModel: yes, should be OK 🤔

[ppaulis]

@Ocramius ok, do you have a suggestion of how to implement this?
I see a few possibilities here, but ultimately it leads me to thinking that JsonModel shouldn't inherit from ViewModel and that ModelInterface contains a lot of stuff that is not necessary for JsonModel...

[Ocramius]

@ppaulis JsonModel could declare its own __construct, with more types (mixed comes to mind, to be honest)

[ppaulis]

@Ocramius so we continue relying on the same code with new tests for JsonModel specifically (haven't deep-dived into the existing tests yet), testing the discussed JSON format. And when the day comes that the ViewModel would no longer support integer-indexes, we would need to think about how to keep the JsonModel running.

if that's ok, I'll send you over a new PR until end of the week.

[froschdesign]

@gsteel
What are you planning for version 3.0 on this?

[gsteel]

Rendering Strategies are, IMO, MVC specific - it's been a while since I had time to allocate to view, but I think my initial plan was to move the rendering strategies to the as yet un-released laminas-mvc-view component.