Add new Validator: HostWithPublicIPv4Address
#257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst doing some refactoring for v3, I found that the Email Address validator validates IP addresses/hostnames for reserved IPs. In order to test this effectively, it makes more sense to implement this as a validator and compose that into the Email address validator - it is likely to prove useful to some users too in a standalone context. So, this validator is a pretty straightforward extraction of https://github.com/laminas/laminas-validator/blob/2.57.x/src/EmailAddress.php#L282-L344 The expectation is that the functionality in the Email validator will be replaced with this. Signed-off-by: George Steel <[email protected]>
gsteel
force-pushed
the
v2/reserved-ip-v4-validator
branch
from
670d16d to
754fe72
Compare
boesing
reviewed
Jun 14, 2024
Ocramius
reviewed
Jun 14, 2024
Ocramius
reviewed
Jun 14, 2024
…so make use of PHP's built-in filters for (assumed) improved performance. Signed-off-by: George Steel <[email protected]>
boesing
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whilst doing some refactoring for v3, I found that the Email Address validator validates IP addresses/hostnames for reserved IPs.
In order to test this effectively, it makes more sense to implement this as a validator and compose that into the Email address validator - it is likely to prove useful to some users too in a standalone context.
So, this validator is a pretty straightforward extraction of https://github.com/laminas/laminas-validator/blob/2.57.x/src/EmailAddress.php#L282-L344
The expectation is that the functionality in the Email validator will be replaced with this.