Run PHP 8.4 in CI #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gsteel
commented
Aug 8, 2024
gsteel
commented
| Q | A |
|---|---|
| QA | yes |
Signed-off-by: George Steel <[email protected]>
boesing
reviewed
Aug 8, 2024
| { | ||
| "additional_checks": [ | ||
| { | ||
| "name": "Run Tests on 8.4", |
There was a problem hiding this comment.
This shouldn't be necessary. Even lowest should be properly handled via ignore_php_platform_requirements as we added that newish composer feature: --ignore-platform-req=php+ (which respects upper bounds)
There was a problem hiding this comment.
Oh, nvm:
laminas/laminas-continuous-integration-action#179
Maybe implement that first so we can leave this alone.
There was a problem hiding this comment.
👍 I'm just mucking around really - I didn't know how to run checks for PHP versions not listed in composer.json. Led me to find this issue: laminas/laminas-ci-matrix-action#310
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.