Improve type inference for plugin manager implementations

[gsteel]

Q	A
QA	yes

Description

Improves type inference particularly for plugin managers in dependent libs

[boesing]

Just a side-note here:

I was about adding this in #98
Back then, @Ocramius told me that this would be a soft BC break due to the way how generics work. So when generic declaration is missing, this will become very messy in projects after upgrading to the version introducing generics.

Therefore, I deferred that to servicemanager v4

[Ocramius]

LGTM - should we 🚢 ?

[Ocramius]

Back then, @Ocramius told me that this would be a soft BC break due to the way how generics work.

I think this only applies to our latest CI builds, where psalm would complain about a non-provided template parameter?

I'd say this is good improvement, and doesn't affect the API per se, just documentation. Downstream consumers that use psalm are used to upgrades "shifting" the types a bit, and will adjust.

[boesing]

I'd say this is good improvement, and doesn't affect the API per se, just documentation. Downstream consumers that use psalm are used to upgrades "shifting" the types a bit, and will adjust.

I'm fine with this.

Anyways: we need to adjust our own components as well, which are quite a lot.
Can we probably create a project for this and list all components which need work then?

Thinking about:

• input filters
• validators
• cache adapters
• cache plugins (or did I killed that? not 100% sure...)
• form elements
• etc.

(btw: with we I mean "not me" 😄)

[Ocramius]

Can we probably create a project for this and list all components which need work then?

I wonder if the installation of renovate (which didn't happen yet, I know, sorry :( ) would already handle this?

[boesing]

I wonder if the installation of renovate would already handle this?

Since I don't think that renovate will create a list of components where the update to the latest servicemanager version fails, I'd say no. And I doubt that all the affected projects do have renovate setup anyways.

[Ocramius]

Well, psalm would fail there, and renovate would open a PR :D

[froschdesign]

Can we probably create a project for this and list all components which need work then?

I can create the project to track the progress and to give an overview.

[Ocramius]

@froschdesign please do: I just tried creating one, and it messed up everything, possibly because I have 2 versions of GitHub Projects on my system (the pre-release one too)

[Ocramius]

Meanwhile, 🚢 here.

[froschdesign]

@gsteel @Ocramius @boesing
With some delay, here is a first start: https://github.com/orgs/laminas/projects/21