Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for php:<7, since support was dropped #100

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Remove check for php:<7, since support was dropped #100

merged 2 commits into from
Aug 3, 2021

Conversation

internalsystemerror
Copy link
Member

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

Since support for PHP < 7.3 was dropped in v3.6 of this library, the check for PHP < 7 can be removed.

@Ocramius Ocramius added this to the 3.8.0 milestone Aug 3, 2021
@Ocramius Ocramius self-assigned this Aug 3, 2021
@Ocramius
Copy link
Member

Ocramius commented Aug 3, 2021

@internalsystemerror could you check these two CS failures, please?

Error: Type explode is not used in this file.
Error: Type strpos is not used in this file.

@internalsystemerror
Copy link
Member Author

@internalsystemerror could you check these two CS failures, please?

Error: Type explode is not used in this file.
Error: Type strpos is not used in this file.

Thanks for approving the workflow. Changes made as requested.

@Ocramius
Copy link
Member

Ocramius commented Aug 3, 2021

Thanks again! 🚢

@Ocramius Ocramius merged commit a536d4d into laminas:3.8.x Aug 3, 2021
@Ocramius Ocramius changed the title Remove check for PHP < 7 since support was dropped Remove check for php:<7, since support was dropped Aug 3, 2021
@internalsystemerror internalsystemerror deleted the hotfix/clean-dead-code branch August 3, 2021 15:39
@boesing
Copy link
Member

boesing commented Aug 3, 2021

I already see this conflicting with #98 :-(
I've removed this as well.

@Ocramius
Copy link
Member

Ocramius commented Aug 3, 2021

@boesing happens, heh :-\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants