-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
laminas/laminas-coding-standard:^3.0 + Apply code style #175
Conversation
Signed-off-by: fezfez <[email protected]>
Signed-off-by: fezfez <[email protected]>
Signed-off-by: fezfez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work here @fezfez 👍
Signed-off-by: fezfez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me @fezfez Thank you - I'd like another pair of eyes on it though, because it's a big patch.
cc @laminas/technical-steering-committee
Yep, let me know when it's ok, I will rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done a spot check, and it basically looks fine - with the caveat of the _autoload.php
file, where phpcs was a bit aggressive in changing a non-existent class name.
Signed-off-by: fezfez <[email protected]>
@weierophinney done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fezfez and @weierophinney :)
No description provided.