Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

laminas/laminas-coding-standard:^3.0 + Apply code style #175

Merged
merged 9 commits into from
Nov 21, 2024

Conversation

fezfez
Copy link
Contributor

@fezfez fezfez commented Nov 14, 2024

No description provided.

Signed-off-by: fezfez <[email protected]>
Signed-off-by: fezfez <[email protected]>
Signed-off-by: fezfez <[email protected]>
phpcs.xml Outdated Show resolved Hide resolved
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work here @fezfez 👍

phpcs.xml Outdated Show resolved Hide resolved
src/ApplicationInterface.php Outdated Show resolved Hide resolved
src/Controller/ControllerManager.php Outdated Show resolved Hide resolved
src/Controller/ControllerManager.php Outdated Show resolved Hide resolved
src/Controller/ControllerManager.php Outdated Show resolved Hide resolved
src/Service/ControllerManagerFactory.php Outdated Show resolved Hide resolved
src/Service/DispatchListenerFactory.php Outdated Show resolved Hide resolved
src/Service/EventManagerFactory.php Outdated Show resolved Hide resolved
src/Service/ServiceListenerFactory.php Outdated Show resolved Hide resolved
src/View/Http/InjectTemplateListener.php Outdated Show resolved Hide resolved
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @fezfez Thank you - I'd like another pair of eyes on it though, because it's a big patch.

cc @laminas/technical-steering-committee

@fezfez
Copy link
Contributor Author

fezfez commented Nov 20, 2024

This looks good to me @fezfez Thank you - I'd like another pair of eyes on it though, because it's a big patch.

cc @laminas/technical-steering-committee

Yep, let me know when it's ok, I will rebase

@gsteel gsteel changed the base branch from 3.8.x to 3.9.x November 21, 2024 11:22
@gsteel gsteel added Enhancement QA Quality assurance tasks such as static analysis improvements labels Nov 21, 2024
Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done a spot check, and it basically looks fine - with the caveat of the _autoload.php file, where phpcs was a bit aggressive in changing a non-existent class name.

phpcs.xml Show resolved Hide resolved
test/_autoload.php Outdated Show resolved Hide resolved
Signed-off-by: fezfez <[email protected]>
@fezfez
Copy link
Contributor Author

fezfez commented Nov 21, 2024

I've done a spot check, and it basically looks fine - with the caveat of the _autoload.php file, where phpcs was a bit aggressive in changing a non-existent class name.

@weierophinney done

Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fezfez and @weierophinney :)

@gsteel gsteel self-assigned this Nov 21, 2024
@gsteel gsteel added this to the 3.9.0 milestone Nov 21, 2024
@gsteel gsteel merged commit a495029 into laminas:3.9.x Nov 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement QA Quality assurance tasks such as static analysis improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants