Add support for PHP 8.4, Upgrade PHPUnit to 10.x, remove Prophecy dependency and improve unit tests

[fezfez]

No description provided.

[gsteel]

Thank you @fezfez :)

The code changes all look 👌 but can you please add to PHPUnit config failOnDeprecation along with failOn… PhpUnitDeprecation|Error|Warning|Notice and re-push - there are some deprecations in the tests that are currently going unnoticed and they may or may not be problematic

[fezfez]

@gsteel done expect failOnPhpunitDeprecation because of

2 tests triggered 2 PHPUnit deprecations:

1) LaminasTest\Mvc\DispatchListenerTest::testWillNotDispatchWhenAnMvcEventResultIsAlreadySet
Data Provider method LaminasTest\Mvc\DispatchListenerTest::alreadySetMvcEventResultProvider() is not static

/var/www/test/DispatchListenerTest.php:95

2) LaminasTest\Mvc\Service\ViewHelperManagerFactoryTest::testBasePathHelperFactoryCanBeInvokedViaShortNameOrFullClassName
Data Provider method LaminasTest\Mvc\Service\ViewHelperManagerFactoryTest::basePathConfiguration() is not static

/var/www/test/Service/ViewHelperManagerFactoryTest.php:134

those two static method create a mock with $this->createMock(....) and cant be marked as static, it will take some effort to fix this

[fezfez]

@gsteel fail on deprecation also fail on php 8.4 lowest job... Should a disable it too for now?

[gsteel]

Fixing the non-static static data providers will have to be done at some point - can you move the mocks to the test and provide any required data for the mock in the provider?

It's also helpful to set displayDetailsOn{Deprecation|PhpUnitDepreaction|Notice|Warning} in phpunit config so that we can see in the logs what failed.

[fezfez]

@gsteel this time i think it's good :)

[gsteel]

Sorry @fezfez - I missed something, but other than that this is good to go. Thank you :)

[gsteel]

🤦‍♂️ Forgot to add the review comment

[gsteel]

Thanks again @fezfez