Extract default listeners from Application #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Xerkus
force-pushed
the
feature/extract-default-application-listeners
branch
from
7ab32f8 to
877e41e
Compare
Use double-dispatch approach to ensure default listeners are registered. Signed-off-by: Aleksei Khudiakov <[email protected]>
… Application. Signed-off-by: Aleksei Khudiakov <[email protected]>
Signed-off-by: Aleksei Khudiakov <[email protected]>
Xerkus
force-pushed
the
feature/extract-default-application-listeners
branch
from
877e41e to
64b6064
Compare
Signed-off-by: Aleksei Khudiakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to remove Application reliance on service locator pattern default listeners need to be extracted from Application class. Newly introduced ApplicationListenersProvider takes responsibility of registering default listeners.
Its factory is looking for a config key
$config[Application::class]['listeners']for additional listeners, removing the responsibility from application factory.ApplicationListenersProvider is not a PSR listener provider.
It operates exclusively on laminas-eventmanager listener aggregates and does not actually allow listeners to be directly registered.
Another approach I considered was to use config provider and configuration to define default listeners. This double-dispatch approach however is more sound in ensuring listeners are always attached on Application instantiation.
Psalm issues which are not directly related intentionally left unfixed to be handled in a separate PR.
Documentation for the changes is to be done via separate PR. See #58