Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the home menu entry in the main navigation. #74

Merged
merged 1 commit into from
May 22, 2023
Merged

Fixes the home menu entry in the main navigation. #74

merged 1 commit into from
May 22, 2023

Conversation

tyrsson
Copy link
Contributor

@tyrsson tyrsson commented May 21, 2023

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

@tyrsson
Fixes the home menu entry in the main navigation.
97d7864 
Signed-off-by: Joey Smith <[email protected]>

Signed-off-by: Joey Smith <[email protected]>
@froschdesign
Copy link
Member

Reference:

  • Indicate the current item by using aria-current="page" for the current page or aria-current="true" for the current item in a set.

https://getbootstrap.com/docs/5.2/components/navbar/#how-it-works

@Ocramius Ocramius added this to the 2.2.0 milestone May 22, 2023
@Ocramius Ocramius self-assigned this May 22, 2023
@Ocramius
Copy link
Member

Thanks @tyrsson!

@Ocramius Ocramius merged commit e4bfbff into laminas:2.2.x May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tyrsson @froschdesign @Ocramius