Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dep] Remove laminas-cache from extra installer option #44

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

samsonasik
Copy link
Member

Signed-off-by: Abdul Malik Ikhsan [email protected]

Q A
Bugfix yes

Description

Per discussion with @weierophinney and @boesing , the laminas-cache should be removed from prompts install components options as it require one of laminas-cache to be installable.

@Ocramius Ocramius added this to the 1.3.0 milestone Dec 15, 2021
@Ocramius
Copy link
Member

Not sure if this is to be considered a BC break? /cc @boesing

@Xerkus
Copy link
Member

Xerkus commented Dec 15, 2021

I don't believe so. Skeleton is a one-time starting point, not a dependency.

@Xerkus Xerkus merged commit 32aea51 into laminas:1.3.x Dec 15, 2021
@samsonasik samsonasik deleted the remove-laminas-cache branch December 15, 2021 09:54
@boesing
Copy link
Member

boesing commented Dec 15, 2021

@Ocramius As @Xerkus said, skeletons are not semver relevant as they're not required as a dependency but created with composer create-project and thus there is usually no relation to this repository.
Afaik, composer create-project removes the .git directory when finished. Or at least does not refer to this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants