Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extra] Using latest components under extra in composer.json #39

Merged
merged 4 commits into from
Jun 1, 2021

Conversation

samsonasik
Copy link
Member

Signed-off-by: Abdul Malik Ikhsan [email protected]

Q A
QA yes

Description

@samsonasik samsonasik added this to the 1.2.0 milestone May 31, 2021
@samsonasik
Copy link
Member Author

samsonasik commented May 31, 2021

The extra components that not installable under PHP 8 are:

  1. laminas-mvc-console < -- deprecated, remove it ?
  2. laminas-cache <-- possibly need to be excluded as it may need to wait for version 3.0 ? /cc @boesing
  3. laminas-test <-- on Provide PHP 8.0 support laminas-test#18

@samsonasik samsonasik requested a review from boesing June 1, 2021 07:33
@froschdesign
Copy link
Member

froschdesign commented Jun 1, 2021

@samsonasik

  1. laminas-mvc-console < -- deprecated, remove it ?

The component is deprecated, so the skeleton application should no longer suggest it.

  1. laminas-test <-- on laminas/laminas-test#18

It would make sense to create a release for laminas-test with PHP 8 support first. Pull requests for all required changes should be available.

Signed-off-by: Abdul Malik Ikhsan <[email protected]>
@samsonasik samsonasik force-pushed the latest-components-extra branch from ce9bc59 to 71d5104 Compare June 1, 2021 11:22
@samsonasik
Copy link
Member Author

@froschdesign thank you, I removed laminas-mvc-console from the extra list.

@Xerkus
Copy link
Member

Xerkus commented Jun 1, 2021

The component is deprecated, so the skeleton application should no longer suggest it.

As an aside, do we consider laminas-cli package a replacement?

@froschdesign
Copy link
Member

…do we consider laminas-cli package a replacement?

There is a stable release, so this is a good idea! 👍

Signed-off-by: Abdul Malik Ikhsan <[email protected]>
@samsonasik
Copy link
Member Author

@Xerkus @froschdesign I updated to use laminas-cli 3887392

Comment on lines 85 to 89
{
"name": "laminas/laminas-psr7bridge",
"constraint": "^1.2.0",
"constraint": "^1.3.1",
"prompt": "Would you like to use the PSR-7 middleware dispatcher?"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, totally forgot. This should be replaced with laminas/laminas-mvc-middleware at ^2.0

Should I do that in another PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xerkus yes, that's ok 👍

composer.json Outdated
"prompt": "Would you like to install MVC-based console support? (We recommend migrating to zf-console, symfony/console, or Aura.CLI)",
"name": "laminas/laminas-cli",
"constraint": "^1.1.1",
"prompt": "Would you like to install command-line interface support?",
"module": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking laminas-cli. It does not provide or need module

Suggested change
"module": true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed 1dca5cf

Signed-off-by: Abdul Malik Ikhsan <[email protected]>
@Xerkus Xerkus merged commit 5765234 into laminas:1.2.x Jun 1, 2021
@samsonasik samsonasik deleted the latest-components-extra branch June 1, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants