-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Extra] Using latest components under extra in composer.json #39
Conversation
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
The extra components that not installable under PHP 8 are:
|
The component is deprecated, so the skeleton application should no longer suggest it.
It would make sense to create a release for laminas-test with PHP 8 support first. Pull requests for all required changes should be available. |
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
ce9bc59
to
71d5104
Compare
@froschdesign thank you, I removed laminas-mvc-console from the extra list. |
As an aside, do we consider |
There is a stable release, so this is a good idea! 👍 |
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
@Xerkus @froschdesign I updated to use laminas-cli 3887392 |
{ | ||
"name": "laminas/laminas-psr7bridge", | ||
"constraint": "^1.2.0", | ||
"constraint": "^1.3.1", | ||
"prompt": "Would you like to use the PSR-7 middleware dispatcher?" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, totally forgot. This should be replaced with laminas/laminas-mvc-middleware
at ^2.0
Should I do that in another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Xerkus yes, that's ok 👍
composer.json
Outdated
"prompt": "Would you like to install MVC-based console support? (We recommend migrating to zf-console, symfony/console, or Aura.CLI)", | ||
"name": "laminas/laminas-cli", | ||
"constraint": "^1.1.1", | ||
"prompt": "Would you like to install command-line interface support?", | ||
"module": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking laminas-cli
. It does not provide or need module
"module": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed 1dca5cf
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Abdul Malik Ikhsan [email protected]
Description