Psalm integration

[nusphere]

Q	A
QA	yes

Summary
As decided during the Technical-Steering-Committee Meeting on August 3rd, 2020, Laminas wants to implement vimeo/psalm in all packages.

Required

• Create a .psalm.xml in the project root
• Copy and paste the contents from this psalm.xml
• Run $ composer require vimeo/psalm
• Run $ vendor/bin/psalm --set-baseline=psalm-baseline.xml
• Add a composer script static-analysis with the command psalm --shepherd --stats
• Remove Travis Support

Affected Issue:

• closes Psalm integration #26

[nusphere]

@Ocramius - Should travis run here? i implemented a .travis file

[nusphere]

Unfortunately, no travis is currently active in the repo, so I cannot test the pipeline.

Especially since you may want to switch to the GitHub Actions.

So I leave the .travis file in the merge as a template for a possible use of Travis or as a template for the GitHub actions.

[froschdesign]

@nusphere

Especially since you may want to switch to the GitHub Actions.

We have to switch. See: https://github.com/laminas/technical-steering-committee/blob/eabf308b50272785d5d04c72fc3c64e0a7d7a2c9/meetings/minutes/2020-11-02-TSC-Minutes.md#github-actions

So I leave the .travis file in the merge…

Can be removed.

[nusphere]

@froschdesign

on the one hand the skeleton is delivered without qa tooling, on the other hand these should be supported.
what applies to "require-dev"?

if psalm is used as a tooling and should be preinstalled (as required in the issue) laminas-test is also required.
Psalm as such belongs in the dev part of the composer.

or should all dependencies be removed (including laminas test) and then these errors ignored based on the baseline?

[nusphere]

documentation adjusted and require dev's removed

[samsonasik]

I think we can do with :

/** @var array $config */
$config = include __DIR__ . '/../config/module.config.php';
return $config;

instead of (array) cast as the config/module.config.php is an array already.

[samsonasik]

@nusphere Thank you, I've handled infer return type at Module::getConfig() during merge.