This repository has been archived by the owner on Feb 24, 2021. It is now read-only.
php8.0 upgrade #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanvandekaa
force-pushed
the
feature-8/php8.0
branch
2 times, most recently
from
8b7906b
to
98264f0
Compare
stefanvandekaa
force-pushed
the
feature-8/php8.0
branch
2 times, most recently
from
792e754
to
8b6e631
Compare
Signed-off-by: Stefan Van de Kaa <[email protected]>
stefanvandekaa
force-pushed
the
feature-8/php8.0
branch
from
8b6e631
to
2641c59
Compare
|
Sorry for the many updates. was my first PR on the Laminas project. Know now how to do it proper for the next time :) |
Ocramius
suggested changes
Dec 24, 2020
Signed-off-by: Stefan Van de Kaa <[email protected]>
|
LGTM! What is potentially still a merge blocker (not to be done here - need to ask in the contributors slack channel) is whether we need to add the release automation toolchain here 🤔 |
|
Decided to release manually: component is deprecated and shouldn't be maintained, but indeed you already put in the effort to get it moving forward, so let's roll with a manual release :-) |
|
Released under https://github.com/laminas/laminas-mvc-console/releases/tag/1.3.0 - thanks @stefanvandekaa! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8
Signed-off-by: Stefan Van de Kaa [email protected]