Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: synchronize globbing with config aggregator #25

Conversation

boesing
Copy link
Member

@boesing boesing commented May 27, 2021

Q A
Bugfix yes

Description

In zendframework/zend-config-aggregator#14, there was a bugfix to force the glob fallback as the merge order on FreeBSD systems is not preserved.
I've recently experienced the same issue with MacOS in combination with the modulemanager and thus I prepared a patch.

/cc @weierophinney

@boesing boesing added the Bug Something isn't working label May 27, 2021
@boesing boesing added this to the 2.10.3 milestone May 27, 2021
@boesing boesing requested a review from weierophinney July 26, 2021 21:53
@boesing boesing linked an issue Jul 26, 2021 that may be closed by this pull request
@Xerkus
Copy link
Member

Xerkus commented Oct 9, 2021

Since this fix potentially changing behavior, I am going to move it to minor release.

@Xerkus Xerkus modified the milestones: 2.10.3, 2.11.0 Oct 9, 2021
@Xerkus Xerkus changed the base branch from 2.10.x to 2.11.x October 9, 2021 14:45
@Xerkus Xerkus merged commit 086f4b2 into laminas:2.11.x Oct 9, 2021
@boesing boesing deleted the qa/synchronize-globbing-with-config-aggregator branch October 10, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge order of config files on FreeBSD-based systems is invalid
2 participants