Add Content-Security-Policy-Report-Only header #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
Just adding a comment in support of merging this; looks like a safe change to me. In case anyone is concerned about the failing test, this looks to be the same failure that is affecting master (and which is apparently addressed by #31). It might be a good idea for @xmorave2 to merge the latest master into this PR, though, in case it clarifies the Travis failure messages (since right now, what I'm seeing here looks a little different from what I'm seeing in master). |
|
please rebase against latest develop branch |
xmorave2
force-pushed
the
CSP-Report-Only
branch
from
82dcbcb
to
fabce24
Compare
xmorave2
force-pushed
the
CSP-Report-Only
branch
from
fabce24
to
26d4ce8
Compare
thanks @samsonasik now I use branch develop and I also add sign-off line to my commit |
|
Is there something what could I do to have this merged? Thanks |
weierophinney
added a commit
that referenced
this pull request
Jun 23, 2020
- Adds CHANGELOG entry for #33 - Sets release date in CHANGELOG for 2.12.0 - Updates branch-aliases: - dev-master => 2.12.x-dev - dev-develop => 2.13.x-dev Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Content-Security-Policy-Report-Only header could be useful when experimenting with policies without impact of you application.