Skip to content

Commit

Permalink
Baseline complaints of less specific return types for `getInputFilter…
Browse files Browse the repository at this point in the history 
…Specification` - a psalm type will need to be imported here from `inputfilter`

Signed-off-by: George Steel <[email protected]>
  • Loading branch information
@gsteel
gsteel committed Jul 25, 2022
1 parent e7ac0b4 commit 9c1bfa1
Showing 1 changed file with 139 additions and 15 deletions.
154 changes: 139 additions & 15 deletions psalm-baseline.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@
<code>getAttributes</code>
</UndefinedMethod>
</file>
<file src="src/Annotation/Attributes.php">
<UndefinedAttributeClass occurrences="1">
<code>Attribute</code>
</UndefinedAttributeClass>
</file>
<file src="src/Annotation/BuilderAbstractFactory.php">
<InvalidStringClass occurrences="1">
<code>new $requestedName()</code>
Expand Down Expand Up @@ -76,14 +71,27 @@
<code>$this</code>
</LessSpecificReturnStatement>
</file>
<file src="src/Element/AbstractDateTime.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="src/Element/Captcha.php">
<DocblockTypeContradiction occurrences="1">
<code>gettype($captcha)</code>
</DocblockTypeContradiction>
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
<RedundantConditionGivenDocblockType occurrences="1">
<code>is_object($captcha)</code>
</RedundantConditionGivenDocblockType>
</file>
<file src="src/Element/Checkbox.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="src/Element/Collection.php">
<DocblockTypeContradiction occurrences="4">
<code>$this-&gt;object instanceof Traversable</code>
Expand Down Expand Up @@ -113,14 +121,67 @@
<code>bindValues</code>
</TooManyArguments>
</file>
<file src="src/Element/Color.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="src/Element/Csrf.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="src/Element/DateSelect.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="src/Element/DateTimeSelect.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="src/Element/Email.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="src/Element/File.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="src/Element/MonthSelect.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="src/Element/Number.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="src/Element/Select.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
<MissingClosureParamType occurrences="1">
<code>$value</code>
</MissingClosureParamType>
<MissingClosureReturnType occurrences="1">
<code>static function ($value) use ($unselectedValue) {</code>
</MissingClosureReturnType>
</file>
<file src="src/Element/Tel.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="src/Element/Url.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="src/ElementFactory.php">
<InvalidStringClass occurrences="1">
<code>new $requestedName($name, $options)</code>
Expand Down Expand Up @@ -173,15 +234,19 @@
<code>$childFieldset</code>
<code>$filter</code>
</ArgumentTypeCoercion>
<InvalidArgument occurrences="1">
<code>$spec</code>
</InvalidArgument>
<LessSpecificReturnStatement occurrences="3">
<code>$this</code>
<code>$this</code>
<code>$this</code>
</LessSpecificReturnStatement>
<PossiblyInvalidArgument occurrences="3">
<PossiblyInvalidArgument occurrences="4">
<code>$collectionInputFilter-&gt;get($name)</code>
<code>$input</code>
<code>$inputFilter</code>
<code>$spec</code>
</PossiblyInvalidArgument>
<PossiblyNullArgument occurrences="1">
<code>$this-&gt;data</code>
Expand Down Expand Up @@ -491,10 +556,10 @@
<code>$form</code>
</MissingClosureParamType>
</file>
<file src="test/TestAsset/Annotation/ComplexEntity.php">
<DeprecatedClass occurrences="1">
<code>Annotation\AllowEmpty()</code>
</DeprecatedClass>
<file src="test/TestAsset/AddressFieldset.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="test/TestAsset/Annotation/InputFilterInput.php">
<DeprecatedInterface occurrences="1">
Expand All @@ -506,11 +571,25 @@
<code>$username</code>
</MissingPropertyType>
</file>
<file src="test/TestAsset/Annotation/SampleEntity.php">
<DeprecatedClass occurrences="2">
<code>Annotation\AllowEmpty(true)</code>
<code>Annotation\ContinueIfEmpty(true)</code>
</DeprecatedClass>
<file src="test/TestAsset/BasicFieldset.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="test/TestAsset/CategoryFieldset.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="test/TestAsset/CityFieldset.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="test/TestAsset/CountryFieldset.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="test/TestAsset/CustomCollection.php">
<PropertyNotSetInConstructor occurrences="1">
Expand All @@ -529,6 +608,16 @@
<code>$this-&gt;view</code>
</PossiblyNullArgument>
</file>
<file src="test/TestAsset/ElementWithFilter.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="test/TestAsset/ElementWithStringToArrayFilter.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="test/TestAsset/FieldsetWithDependency.php">
<MissingParamType occurrences="2">
<code>$name</code>
Expand All @@ -538,7 +627,15 @@
<code>$dependency</code>
</PropertyNotSetInConstructor>
</file>
<file src="test/TestAsset/FieldsetWithInputFilter.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array[]</code>
</LessSpecificImplementedReturnType>
</file>
<file src="test/TestAsset/FileInputFilterProviderFieldset.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array[]</code>
</LessSpecificImplementedReturnType>
<MissingParamType occurrences="2">
<code>$name</code>
<code>$options</code>
Expand All @@ -551,29 +648,56 @@
</MissingParamType>
</file>
<file src="test/TestAsset/InputFilterProvider.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array[]</code>
</LessSpecificImplementedReturnType>
<MissingParamType occurrences="2">
<code>$name</code>
<code>$options</code>
</MissingParamType>
</file>
<file src="test/TestAsset/InputFilterProviderFieldset.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array[]</code>
</LessSpecificImplementedReturnType>
<MissingParamType occurrences="2">
<code>$name</code>
<code>$options</code>
</MissingParamType>
</file>
<file src="test/TestAsset/InputFilterProviderWithFieldset.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array[]</code>
</LessSpecificImplementedReturnType>
<MissingParamType occurrences="2">
<code>$name</code>
<code>$options</code>
</MissingParamType>
</file>
<file src="test/TestAsset/MyFieldset.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array[]</code>
</LessSpecificImplementedReturnType>
</file>
<file src="test/TestAsset/NestedFieldset.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="test/TestAsset/OrphansFieldset.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array[]</code>
</LessSpecificImplementedReturnType>
<MissingParamType occurrences="2">
<code>$name</code>
<code>$options</code>
</MissingParamType>
</file>
<file src="test/TestAsset/ProductFieldset.php">
<LessSpecificImplementedReturnType occurrences="1">
<code>array</code>
</LessSpecificImplementedReturnType>
</file>
<file src="test/TestAsset/ValueStoringFieldset.php">
<PropertyNotSetInConstructor occurrences="1">
<code>$storedValue</code>
Expand Down

0 comments on commit 9c1bfa1

Please sign in to comment.