Refactor StripTags filter to implement FlterInterface #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctFilter support Signed-off-by: Marcel Thole <[email protected]>
marcelthole
force-pushed
the
refactor-striptags-filter
branch
from
7395ec0 to
2b20abb
Compare
Signed-off-by: Marcel Thole <[email protected]>
marcelthole
force-pushed
the
refactor-striptags-filter
branch
from
2b20abb to
ee475e1
Compare
…ly properties Signed-off-by: George Steel <[email protected]>
gsteel
approved these changes
Jan 4, 2025
There was a problem hiding this comment.
Thanks @marcelthole
I added another commit to further simplify the options as readonly properties without a private setter method. Also, the options were tightened up so that tags are always array<string, list<string>> and global attributes are list<string>.
I would have done this via review, but was having trouble communicating my intentions!
This was referenced Jan 4, 2025
froschdesign
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move StripTags filter also to the implementation via FilterInterface and removed the AbstractFilter