Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SeparatorToSeparator Deprecations #211

Merged
merged 1 commit into from
Dec 18, 2024
Merged

SeparatorToSeparator Deprecations #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,6 +1179,8 @@
<code><![CDATA[UriNormalize::class]]></code>
<code><![CDATA[UriNormalize::class]]></code>
<code><![CDATA[Whitelist::class]]></code>
<code><![CDATA[Word\Service\SeparatorToSeparatorFactory::class]]></code>
<code><![CDATA[Word\Service\SeparatorToSeparatorFactory::class]]></code>
</DeprecatedClass>
<DuplicateArrayKey>
<code><![CDATA[ToInt::class => InvokableFactory::class]]></code>
Expand Down Expand Up @@ -1614,6 +1616,10 @@
<DeprecatedClass>
<code><![CDATA[AbstractFilter]]></code>
</DeprecatedClass>
<DeprecatedMethod>
<code><![CDATA[setReplacementSeparator]]></code>
<code><![CDATA[setSearchSeparator]]></code>
</DeprecatedMethod>
<DocblockTypeContradiction>
<code><![CDATA[$this->searchSeparator === null]]></code>
</DocblockTypeContradiction>
Expand Down Expand Up @@ -2091,6 +2097,12 @@
<code><![CDATA[$container]]></code>
</UnusedClosureParam>
</file>
<file src="test/FilterPluginManagerTest.php">
<DeprecatedMethod>
<code><![CDATA[getReplacementSeparator]]></code>
<code><![CDATA[getSearchSeparator]]></code>
</DeprecatedMethod>
</file>
<file src="test/ForceUriSchemeTest.php">
<PossiblyUnusedMethod>
<code><![CDATA[badSchemeProvider]]></code>
Expand Down
12 changes: 10 additions & 2 deletions src/Word/SeparatorToSeparator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ public function __construct($searchSeparator = ' ', $replacementSeparator = '-')
/**
* Sets a new separator to search for
*
* @param string $separator Separator to search for
* @deprecated This method will be removed in 3.0.0 without replacement
*
* @param string $separator Separator to search for
* @return self
*/
public function setSearchSeparator($separator)
Expand All @@ -52,6 +54,8 @@ public function setSearchSeparator($separator)
/**
* Returns the actual set separator to search for
*
* @deprecated This method will be removed in 3.0.0 without replacement
*
* @return string
*/
public function getSearchSeparator()
Expand All @@ -62,7 +66,9 @@ public function getSearchSeparator()
/**
* Sets a new separator which replaces the searched one
*
* @param string $separator Separator which replaces the searched one
* @deprecated This method will be removed in 3.0.0 without replacement
*
* @param string $separator Separator which replaces the searched one
* @return self
*/
public function setReplacementSeparator($separator)
Expand All @@ -74,6 +80,8 @@ public function setReplacementSeparator($separator)
/**
* Returns the actual set separator which replaces the searched one
*
* @deprecated This method will be removed in 3.0.0 without replacement
*
* @return string
*/
public function getReplacementSeparator()
Expand Down
6 changes: 5 additions & 1 deletion src/Word/Service/SeparatorToSeparatorFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@
use function iterator_to_array;
use function sprintf;

/** @final */
/**
* @deprecated This factory will be removed in 3.0.0 without replacement
*
* @final
*/
class SeparatorToSeparatorFactory implements FactoryInterface
{
/**
Expand Down
Loading