Refactor FilterChain
#208
Merged
Refactor FilterChain
#208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors filter chain to require the plugin manager as a constructor dependency and… - Drops `setOptions` - Removes inheritance - Implement newly added `FilterChainInterface` - Remove the constant `DEFAULT_PRIORITY` - Drops getter and setter for the plugin manager - Drops the `plugin` method - Drops `getFilter` - Stops pretending that chains can be serialized Introduces `ImmutableFilterChain` which is effectively the same as `FilterChain` but immutable and lacks the `merge` method which has limited use cases. `ImmutableFilterChain` and `FilterChainInterface` can be backported to 2.x so that libs can switch to it (input-filter, form etc) without breaking BC _(Possibly)_ Signed-off-by: George Steel <[email protected]>
froschdesign
approved these changes
Dec 12, 2024
Signed-off-by: George Steel <[email protected]>
|
@froschdesign |
gsteel
added a commit
to gsteel/laminas-filter
that referenced
this pull request
Dec 17, 2024
See laminas#208 Signed-off-by: George Steel <[email protected]>
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors filter chain to require the plugin manager as a constructor dependency and…
setOptionsFilterChainInterfaceDEFAULT_PRIORITYpluginmethodgetFilterIntroduces
ImmutableFilterChainwhich is effectively the same asFilterChainbut immutable and lacks themergemethod which has limited use cases.ImmutableFilterChainandFilterChainInterfacecan be backported to 2.x so that libs can switch to it (input-filter, form etc) without breaking BC (Possibly)Docs are still todo but feedback appreciated 👍