Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated AbstractFilter::hasPcreUnicodeSupport method #146

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jun 13, 2024

This method has been irrelevant since around PHP 5.3 ish…

This method has been irrelevant since around PHP 5.3 ish…

Signed-off-by: George Steel <[email protected]>
@gsteel gsteel added this to the 3.0.0 milestone Jun 13, 2024
Copy link
Member

@boesing boesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Method is deprecated anyways and thus safely to remove in next major.

@gsteel gsteel merged commit 2d096c8 into laminas:3.0.x Jun 13, 2024
11 of 12 checks passed
@gsteel gsteel deleted the v3/remove-pcre-unicode-support branch June 13, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants