Fixes regression in FilterChain options, allows callback to be an instance of FilterInterface again. #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
baldwinagency-pieter
force-pushed
the
fix-regression-with-filterinterface-235x
branch
3 times, most recently
from
3ac1097 to
bfdaf80
Compare
Signed-off-by: Pieter Hoste <[email protected]>
baldwinagency-pieter
force-pushed
the
fix-regression-with-filterinterface-235x
branch
from
bfdaf80 to
ea501a5
Compare
|
@Ocramius: all tests are green, can be reviewed, thanks! :) |
Xerkus
changed the title
|
@hostep thank you |
|
Thanks for the quick merge and release! |
|
Thanks for fixing my mistake @hostep 🤦♂️ |
|
@hostep Nice work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes regression bug introduced by https://github.com/laminas/laminas-filter/pull/124/files#diff-3a6c9663e22963eb296b993e0b7cc8335c9f7f02f8364fc66385ed7175b5639dL89
The
attachmethod can take acallableor aFilterInterface, however, with the added check on onlyis_callable, this breaks applying filters from classes that implementFilterInterfaceSee magento/magento2#38610 for how this breaks in Magento
This PR fixes this.
I tried to fix new problems psalm reports, but am unable to fix them, some help would be appreciated!Update: fixed, somehow the psalm cache was corrupt during my tests, so my initial fix did work in the end.