Remove the UriNormalize filter
#131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also drops the dependency on `laminas-uri` Signed-off-by: George Steel <[email protected]>
We need a new issue report for this, otherwise it will be forgotten. |
Ocramius
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further to #110, this patch removes the filter and the dependency on
laminas-uri.My main argument for removal vs re-implementing is that it'll be a lot easier to re-introduce a filter that forces a string uri to use a specific scheme (And name it something like
ForceUriScheme) than it will be to preserve BC with whatever laminas-uri was doing.As a result we have fewer dependencies that also help pave the way to Laminas ServiceManager v4
Closes #110