Add mixed parameter and return types to FilterInterface
#111
Conversation
gsteel
changed the title
mixed parameter and return types to FilterInterface
psalm-baseline.xml
Outdated
| <InvalidArgument> | ||
| <code>array_values($processedParts)</code> | ||
| </InvalidArgument> |
There was a problem hiding this comment.
Anything worth investigating here?
There was a problem hiding this comment.
Nah. This is psalm better understanding how little it understands this existing code. My current plan is to get native types everywhere and whittle down the baseline as much as poss for v3, so it's something I should get to later on.
| @@ -85,7 +85,7 @@ public function getList() | |||
| * | |||
| * Will return $value if its present in the white-list. If $value is rejected then it will return null. | |||
| */ | |||
| public function filter($value) | |||
| public function filter(mixed $value): mixed | |||
There was a problem hiding this comment.
Could be refined to return one of the values of the specified list, or null
| @@ -206,9 +206,8 @@ public function getTranslations() | |||
| * Returns a boolean representation of $value | |||
| * | |||
| * @param null|array|bool|float|int|string $value | |||
| */ | ||
| public function filter($value) | ||
| public function filter(mixed $value): mixed | ||
| { | ||
| if (! is_string($value) && $value !== null) { |
There was a problem hiding this comment.
I'll have to look closer at this later on, but I think that some of the adapters only work on files passed as options (Those adapters might be dead now), therefore there's no argument to filter(), or something like that…
Not sure I understand this… This patch is just meant to nail down the contract of |
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
…lock descriptions Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
gsteel
force-pushed
the
mixed-types-for-filter-interface
branch
from
1f56f4e to
58aae6c
Compare
Description
Adds parameter and return type of
mixedtoFilterInterface::filter()and all implementations.Some additional property/parameter/return types have been added but avoided where possible.
The plan here is to add types everywhere in another patch later on.