Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PHPUnit to 10.1.x #47

Open
wants to merge 3 commits into
base: 2.14.x
Choose a base branch
from
Open

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Apr 18, 2023

Needs #46
Closes #43

@gsteel
Copy link
Member Author

gsteel commented Apr 18, 2023

Ughh. Infection won't pass without laminas/laminas-continuous-integration-action#130

@Ocramius Ocramius removed this from the 2.13.0 milestone Oct 10, 2023
@gsteel gsteel changed the base branch from 2.13.x to 2.14.x December 12, 2023 15:37
@gsteel gsteel added this to the 2.14.0 milestone Dec 12, 2023
@gsteel
Copy link
Member Author

gsteel commented Dec 12, 2023

@Ocramius I've disabled infection here so that the PHPUnit 10 upgrade can go through.

Would it be preferable to manually add a job to CI that doesn't use the laminas container or can we just re-enable it when phpdbg is dropped from the CI container?

@Ocramius
Copy link
Member

IMO going from PHPUnit 9 to PHPUnit 10 and losing infection is worse than keeping on PHPUnit 9, for now 🤔

@froschdesign froschdesign mentioned this pull request Oct 8, 2024
@gsteel gsteel removed this from the 2.14.0 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants