Support for web servers that send HTTP2 request protocol as HTTP/2.0. Fixes #71

[JakeBooher]

Q	A
Documentation	no
Bugfix	yes
BC Break	no
New Feature	no
RFC	no
QA	no

Description

Fixes #71

[Ocramius]

Overall patch OK from my PoV, but needs some adjustments for it to be mergeable :)

[Ocramius]

Heyo, check the new type additions:

Error: Providers must return iterable<array-key, array<array-key, mixed>>, possibly different array<array-key, mixed> provided
Error: Providers must return iterable<array-key, array<array-key, mixed>>, possibly different array<array-key, mixed> provided
Error: Providers must return iterable<array-key, array<array-key, mixed>>, possibly different array<array-key, mixed> provided
Error: Providers must return iterable<array-key, array<array-key, mixed>>, possibly different array<array-key, mixed> provided
Error: Providers must return iterable<array-key, array<array-key, mixed>>, possibly different array<array-key, mixed> provided
Error: Providers must return iterable<array-key, array<array-key, mixed>>, possibly different array<array-key, mixed> provided
Error: Argument 2 of Psr\Http\Message\MessageInterface::withHeader expects array<array-key, string>|string, array{float} provided
Error: Argument 2 of Psr\Http\Message\MessageInterface::withHeader expects array<array-key, string>|string, float provided
Error: Providers must return iterable<array-key, array<array-key, mixed>>, possibly different array<array-key, mixed> provided
Error: Providers must return iterable<array-key, array<array-key, mixed>>, possibly different array<array-key, mixed> provided

That's because the provider type declarations should have @return array<array<...>> or such :)

[JakeBooher]

Honestly have no time or interest in digging down that rabbit hole. Nothing even remotely resembling that exists anywhere in that test class, and I've already had to add return type hinting to every method in the class that didn't have it already. We can patch the original issue ourselves in a fork and include that instead if necessary. Feel free to close this PR and its associated issue if needed.

[Ocramius]

I mean, if you think that's the responsible way to behave when trying to help on a project 🤷‍♀️

Sure, you can also just use a fork, but it really shows that you care little for being part of OSS, and are just hoping to reap the benefits.

We'll eventually get to fix it ourselves here, at some point.

[Ocramius]

I've adjusted the added type signatures accordingly - will now roll a release.

Thanks for the initial fix, @JakeBooher.